Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rojo plugin should have a "Never" option for the confirmation behavior setting #891

Closed
kennethloeffler opened this issue Mar 13, 2024 · 0 comments · Fixed by #893
Closed

Rojo plugin should have a "Never" option for the confirmation behavior setting #891

kennethloeffler opened this issue Mar 13, 2024 · 0 comments · Fixed by #893
Assignees
@boatbomber
Labels
good first issue Looking to contribute to Rojo? This is a great place to start! impact: small Minor papercuts in Rojo that don't warrant immediate resolutoin. scope: plugin Relevant to the Roblox Studio plugin size: small status: ready for work Ready to go! We would accept a PR to do this. type: enhancement Feature or improvement that should potentially happen

Comments

@kennethloeffler
Copy link
Member

kennethloeffler commented Mar 13, 2024 •
edited
Loading

Some users do not care about confirming a sync after they click the connect button, and the additional step merely adds friction for them.

I think Rojo should have an additional option for the confirmation behavior setting called "Never." This option would, as the name suggests, never prompt for confirmation of the sync.

It is possible to get this behavior today by using the "Unlisted PlaceId" option, but then users have to find their place ID, edit their project file, and alter this setting, rather than just alter the setting. I think it's also reasonable for people to expect a "Never" option as a counterpart to the "Always" option.
@kennethloeffler kennethloeffler added type: enhancement Feature or improvement that should potentially happen scope: plugin Relevant to the Roblox Studio plugin size: small impact: small Minor papercuts in Rojo that don't warrant immediate resolutoin. status: ready for work Ready to go! We would accept a PR to do this. good first issue Looking to contribute to Rojo? This is a great place to start! labels Mar 13, 2024
@Barocena Barocena mentioned this issue Mar 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@boatbomber boatbomber

Labels
good first issue Looking to contribute to Rojo? This is a great place to start! impact: small Minor papercuts in Rojo that don't warrant immediate resolutoin. scope: plugin Relevant to the Roblox Studio plugin size: small status: ready for work Ready to go! We would accept a PR to do this. type: enhancement Feature or improvement that should potentially happen
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add never option to Confirmation Barocena/rojo
2 participants
@kennethloeffler @boatbomber