Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minimum plugin UI size is too big #592

Closed
ghost opened this issue Jul 26, 2022 · 6 comments · Fixed by #606
Closed

Minimum plugin UI size is too big #592

ghost opened this issue Jul 26, 2022 · 6 comments · Fixed by #606
Labels
scope: plugin Relevant to the Roblox Studio plugin type: enhancement Feature or improvement that should potentially happen

Comments

@ghost
Copy link

ghost commented Jul 26, 2022 •
edited by ghost
Loading

My goal is to maximize my viewport size, and the plugin's minimum length and width is longer and wider than the minimums of Studio's builtin widgets. This causes my panels to become bigger when I merge the plugin widget into them.

I think minimum size is set on line 195.

RobloxStudioBeta_Qox8hBLP7w
RobloxStudioBeta_RbzJHXsTru
@Boegie19 Boegie19 mentioned this issue Jul 30, 2022
Merged
18 tasks
@LPGhatguy LPGhatguy added type: enhancement Feature or improvement that should potentially happen scope: plugin Relevant to the Roblox Studio plugin labels Aug 3, 2022
@LPGhatguy
Copy link
Contributor

This makes sense. If you would file a PR to change the maximum size to match the built-in panels, I think we could merge that to fix this case.

@ghost ghost mentioned this issue Aug 4, 2022
Merged
@boatbomber
Copy link
Member

boatbomber commented Aug 4, 2022 •
edited
Loading

Our UI is not gonna look work at that tiny size. That's a 41% decrease. Things just won't fit correctly anymore.

image image image

@boatbomber
Copy link
Member

Not sure why you went down to 175px, the Output window's minimum is much larger than that.
image

@boatbomber
Copy link
Member

The output widget minimum width is 300... exactly what Rojo's is.
image

@boatbomber
Copy link
Member

I agree we could lower the minimum height at least. That just means more scrolling, but that's not a bit deal the way unreadable text is.

@ghost
Copy link
Author

ghost commented Aug 4, 2022

Made it 300x120 now in line with Output's height.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
scope: plugin Relevant to the Roblox Studio plugin type: enhancement Feature or improvement that should potentially happen
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reduce minimum plugin size
2 participants
@LPGhatguy @boatbomber