Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syncing into non-default services creates folders instead #13

Closed
LPGhatguy opened this issue Dec 11, 2017 · 5 comments
Closed

Syncing into non-default services creates folders instead #13

LPGhatguy opened this issue Dec 11, 2017 · 5 comments
Labels
scope: plugin Relevant to the Roblox Studio plugin type: bug Something happens that shouldn't happen

Comments

@LPGhatguy
Copy link
Contributor

LPGhatguy commented Dec 11, 2017

Right now, if a sync targets a service that isn't instantiated by default like Teams or TestService, that service will just be created as a folder.

The reconciler should attempt to instantiate services inside of the data model before trying to create folders.

The easy workaround for now is to insert the services before trying to sync with Rojo. I think that's reasonable.

@LPGhatguy LPGhatguy added type: bug Something happens that shouldn't happen difficulty: easy scope: plugin Relevant to the Roblox Studio plugin labels Dec 11, 2017
@LPGhatguy
Copy link
Contributor Author

Fixed in latest master.

@LPGhatguy
Copy link
Contributor Author

Not fixed in latest master, agh!

@LPGhatguy LPGhatguy reopened this Jan 15, 2018
@LPGhatguy
Copy link
Contributor Author

Fixed for v0.4.0-pre2!

@nezuo
Copy link
Contributor

nezuo commented Nov 12, 2020

This doesn't seemed to be fixed for me. I am on v6.0.0-rc.1.

Project File:

{
  "name": "Test",
  "tree": {
    "$className": "DataModel",

    "TestService": {
      "$path": "src"
    }
  }
}

Result:
image

This actually may be an unrelated bug. If I add "$className": "TestService" it syncs correctly.

@LPGhatguy
Copy link
Contributor Author

Thanks for looking for an existing bug, but this one is from a very different era of Rojo. 😅

Your issue is the same as #331. I'll update that issue's title to explain the underlying issue and whether we should consider it a bug or just something to document.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: plugin Relevant to the Roblox Studio plugin type: bug Something happens that shouldn't happen
Projects
None yet
Development

No branches or pull requests

2 participants