Rojo 7.4.1

[kennethloeffler]

There are a few bugs and pain points in Rojo 7.4.0 that we should release fixes for soon. Some are longstanding, while others were only introduced in 7.4.0, and still others were caused by some changes from third parties:

• Patch visualizer doesn't display failed instance additions #842
  This is a longstanding bug caused by missing functionality in the patch visualizer. The fix has already been backported to the 7.4.x branch.

• Catch more sync failures #845
  This PR doesn't have any corresponding issues, but fixes a set of longstanding bugs caused by missing functionality in the patch visualizer and some unprotected calls in the reconciler. The fixes have already been backported to the 7.4.x branch.

• Attempting to sync over an existing PackageLink causes Rojo plugin to error out #841
  This is a new bug that was caused by the combination of a change to the reflection database and poor behavior in the plugin's reconciler. The fix has already been backported to the 7.4.x branch.

• Rojo should remove Carriage Returns when syncing on Windows #776
  This is both a longstanding and new bug that was caused by a combination of teams working on multiple OSes, and Roblox normalizing scripts' line endings to LF. The fix has already been backported to the 7.4.x branch.

• Catch failed http requests that didn't error so we can handle them correctly #847
  This PR doesn't have a corresponding issue, but fixes a new bug that was caused by a change around how GitHub Codespaces interacts with long polling. The fix has already been backported to the 7.4.x branch.

Additionally, there are a couple rbx-dom related issues that have not yet had fixes made for them, but that we might want to include in 7.4.1:

• Rojo does not build model pivots correctly when no PrimaryPart is set #628
  This is a longstanding bug that has been present in Rojo ever since the release of Roblox's pivots feature. There's a PR open where we tracked down the actual problems: Fix WorldPivotData not being written in studio rbx-dom#238.

• Temporary workaround for MeshPart.MeshId writes rbx-dom#390
  This is a proposed temporary fix for the longstanding problem of syncing MeshParts (which I'm sure I don't need to explain to this post's intended audience, lol!).

We also have a small request from the roblox-ts team to improve their UX by making the name field in the project format optional:

• Optional top-level default.project.json "name" field #858
  This is small in scope so I'm comfortable slotting it into 7.4.1, as long as we can get it done in time.

I think these changes should go out no later than the end of this week (EOD February 16, 2024).

UPDATE: This has been delayed until February 19th because one of the Rojo team members is sick and did not feel well enough to hit the above deadline. The silver lining is that we'll have more time to address the community requests!

UPDATE 2: This has been delayed again to today (February 20th, 2024)... turns out it was a federal holiday in the US yesterday! 😅

[kennethloeffler]

#628
This is a longstanding bug that has been present in Rojo ever since the release of Roblox's pivots feature. There's a PR open where we tracked down the actual problems: rojo-rbx/rbx-dom#238.

I'm taking this on right now and should have it done today (do we maybe want a kanban board on this repo? 😅)

[kennethloeffler]

PR is up for the build issue at #865, next up is the sync issue, which needs an issue opened for it and will require a reflection db patch and update

[kennethloeffler]

I've opened some issues for the sync issue at #866 and rojo-rbx/rbx-dom#391 and I am starting on the PRs right now

[kennethloeffler]

Alrighty, this is all done and just needs to be merged here at Rojo and backported to the 7.4.x branch

[kennethloeffler]

Rojo 7.4.1 is released! 🎉