Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install JupyterHub as part of install_jupyter.sh #668

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

yuvipanda
Copy link
Contributor

This allows using the built image with JupyterHubs for running RStudio.

@eitsupi eitsupi requested a review from cboettig June 20, 2023 22:25
@eitsupi
Copy link
Member

eitsupi commented Jun 20, 2023

Thanks for working on this!

The CI failure seems nothing to do with this change.

@eitsupi
Copy link
Member

eitsupi commented Jun 20, 2023

(The failed test was fixed in #669)

This allows using the built image with JupyterHubs for
running RStudio.
@yuvipanda
Copy link
Contributor Author

Great! I've rebased on latest...

@cboettig
Copy link
Member

nice!

@eitsupi eitsupi merged commit a97f0ca into rocker-org:master Jun 21, 2023
@yuvipanda
Copy link
Contributor Author

@cboettig do you know when this might make its way to Dockerhub? I see in https://hub.docker.com/r/rocker/binder/tags that the last push was a few days before this PR got merged.

@cboettig
Copy link
Member

@yuvipanda thanks for the ping! looks like the most recent automated build failed, I've tickled a re-build.

@yuvipanda
Copy link
Contributor Author

yay, thanks @cboettig! That works well :)

fwiw, we're starting to recommend people just use the upstream rocker/binder image on 2i2c JupyterHubs when they want to use rstudio (2i2c-org/infrastructure#2726) and thought you might like to know :)

@eitsupi
Copy link
Member

eitsupi commented Jun 27, 2023

@yuvipanda thanks for the ping! looks like the most recent automated build failed, I've tickled a re-build.

Indeed, the reason it was not deployed was not because it did not fail the auto-build, but because this change did not trigger the auto-build in the first place.

Currently, only R or RStudio version upgrades trigger the auto-build, and other builds are triggered manually about once a month on a whim when I see an update to the base image (ubuntu).
I really would like to automatically detect updates to the base image, but have not been able to do so. (Although Dependabot can do it, so perhaps there is a way.)

@cboettig
Copy link
Member

Thanks @eitsupi . I was wondering if we should add a cron trigger to the action to ensure an auto-build of the latest image on a predictable schedule? Maybe once a week? I think it would be nice to ensure that the latest image is a relatively recent build across the board, e.g. that we're not a month behind pulling in patches to security-related libraries that aren't installed in the base image by default, (e.g. network-related libs like openssl / curl). This also serves to keep R packages more up-to-date though that's probably less important.

@yuvipanda
Copy link
Contributor Author

@eddelbuettel
Copy link
Member

I do it too in some GH Actions. They tend to send nastygrams if the repos were commit-less for sixty days so for rocker's r-devel, drd, drp, san I also commit the output of date > timestamp.txt in the action which, while silly, keeps the nastygrams at bay

yuvipanda added a commit to yuvipanda/rocker-versioned2 that referenced this pull request Jun 28, 2023
Based on @cboettig's [comment](rocker-org#668 (comment)):

> I think it would be nice to ensure that the latest image is a
> relatively recent build across the board, e.g. that we're not a month
> behind pulling in patches to security-related libraries that aren't
> installed in the base image by default, (e.g. network-related libs
> like openssl / curl). This also serves to keep R packages more
> up-to-date though that's probably less important.
@yuvipanda
Copy link
Contributor Author

@cboettig @eitsupi I opened #671!

@eitsupi eitsupi mentioned this pull request Jun 28, 2023
@eitsupi
Copy link
Member

eitsupi commented Jun 28, 2023

I have created a new issue #672.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants