-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install JupyterHub as part of install_jupyter.sh #668
Conversation
Thanks for working on this! The CI failure seems nothing to do with this change. |
(The failed test was fixed in #669) |
This allows using the built image with JupyterHubs for running RStudio.
1c6010a
to
8846a0d
Compare
Great! I've rebased on latest... |
nice! |
@cboettig do you know when this might make its way to Dockerhub? I see in https://hub.docker.com/r/rocker/binder/tags that the last push was a few days before this PR got merged. |
@yuvipanda thanks for the ping! looks like the most recent automated build failed, I've tickled a re-build. |
yay, thanks @cboettig! That works well :) fwiw, we're starting to recommend people just use the upstream rocker/binder image on 2i2c JupyterHubs when they want to use rstudio (2i2c-org/infrastructure#2726) and thought you might like to know :) |
Indeed, the reason it was not deployed was not because it did not fail the auto-build, but because this change did not trigger the auto-build in the first place. Currently, only R or RStudio version upgrades trigger the auto-build, and other builds are triggered manually about once a month on a whim when I see an update to the base image ( |
Thanks @eitsupi . I was wondering if we should add a cron trigger to the action to ensure an auto-build of the latest image on a predictable schedule? Maybe once a week? I think it would be nice to ensure that the |
@cboettig yep, cron is what we do in jupyter/docker-stacks (https://github.com/jupyter/docker-stacks/blob/df5d516e34efafc699783008c007cfcc691b164c/.github/workflows/docker.yml#L4) |
I do it too in some GH Actions. They tend to send nastygrams if the repos were commit-less for sixty days so for rocker's r-devel, drd, drp, san I also commit the output of |
Based on @cboettig's [comment](rocker-org#668 (comment)): > I think it would be nice to ensure that the latest image is a > relatively recent build across the board, e.g. that we're not a month > behind pulling in patches to security-related libraries that aren't > installed in the base image by default, (e.g. network-related libs > like openssl / curl). This also serves to keep R packages more > up-to-date though that's probably less important.
I have created a new issue #672. |
This allows using the built image with JupyterHubs for running RStudio.