Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename bionic image definition files and improve test workflow for docker-bake.json #400

Merged
merged 3 commits into from
Apr 2, 2022

Conversation

eitsupi
Copy link
Member

@eitsupi eitsupi commented Apr 1, 2022

Close #399
And, the test for docker-bake.json files is not needed for most Pull Requests, so it is separated into a single workflow file.

Note that this PR only changes the name used in the definition files and does not affect the images to be built.

@eitsupi eitsupi force-pushed the remove-dots-from-target-name branch from 7bbf390 to 8e425ba Compare April 1, 2022 16:21
@eitsupi eitsupi changed the title Rename bionic image files Rename bionic image files and improve test workflow for docker-bake.json Apr 1, 2022
@eitsupi eitsupi changed the title Rename bionic image files and improve test workflow for docker-bake.json Rename bionic image definition files and improve test workflow for docker-bake.json Apr 1, 2022
@cboettig
Copy link
Member

cboettig commented Apr 1, 2022

nice solution, this looks good to me, merge when ready!

@eitsupi eitsupi merged commit cfac661 into rocker-org:master Apr 2, 2022
@eitsupi eitsupi deleted the remove-dots-from-target-name branch April 2, 2022 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

buildx bake command not allow dots in target names (buildx v0.8)
2 participants