Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install_julia.sh doesn't install the latest version of Julia #763

Closed
Hua-Zhou opened this issue Feb 29, 2024 · 2 comments
Closed

install_julia.sh doesn't install the latest version of Julia #763

Hua-Zhou opened this issue Feb 29, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@Hua-Zhou
Copy link
Contributor

This potential bug doesn't affect pre-built images. It only affects users who want to call the script install_julia.sh to install the latest version of Julia in the Docker image.

If a user doesn't specify the environment variable JULIA_VERSION, the current script install_julia.sh will always install Julia v1.9.4, even though the latest stable version of Julia is 1.10.1 now.

Changing this line
latest_version <- sort(versions[is_stable], decreasing = TRUE)[1]
to
latest_version <- as.character(sort(numeric_version(versions[is_stable]), decreasing = TRUE)[1])
should fix the issue.

@eitsupi
Copy link
Member

eitsupi commented Feb 29, 2024

Thanks for the report. Would you be interested in submitting a pull request?

I think this script should ideally be rewritten to use juliaup, but haven't worked on that because I was wondering if there is a user need.

@eitsupi eitsupi added the bug Something isn't working label Feb 29, 2024
Hua-Zhou added a commit to Hua-Zhou/rocker-versioned2 that referenced this issue Feb 29, 2024
@Hua-Zhou
Copy link
Contributor Author

+1 for "juliaup"-ify the script. My use case: I teach courses in a biostatistics department in different languages: R, Python, and Julia. It'll be nice to have an image with the full JUPYTER (Julia+Python+R) stack. I used to build from the math-server-docker, but that's CentOS-based and the build process is unbearably long.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants