Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup MATLAB docs #38

Closed
2 tasks
traversaro opened this issue Feb 2, 2018 · 1 comment · Fixed by #1464
Closed
2 tasks

Cleanup MATLAB docs #38

traversaro opened this issue Feb 2, 2018 · 1 comment · Fixed by #1464

Comments

@traversaro
Copy link
Member

traversaro commented Feb 2, 2018

Dealing with all the different variations of the Matlab install on users computer is typically the biggest bottleneck for new users installing the superbuild, as we saw with @gabrielenava and @ahmadgazar .

Things to cleanup:

  • Clarify how the CMake subprojects of the superbuild are actually finding Matlab. In particular, if the robotology is not able to find Matlab, the user has no guidance on how to setup its system to make sure that matlab is found. As of CMake 3.10 the FindMatlab.cmake is not checking any env variable such as Matlab_ROOT_DIR or MATLAB_DIR, the only reliable way to get CMake to detect matlab is to ensure that this call to find_program is able to find the matlab program: https://github.com/Kitware/CMake/blob/v3.10.2/Modules/FindMatlab.cmake#L1035 . To make sure that find_program finds matlab, it is possible to check the search policy of find_program in CMake's docs : https://cmake.org/cmake/help/v3.8/command/find_program.html?highlight=i . In particular, adding (at least temporary) the directory in which matlab is contained in PATH or CMAKE_PROGRAM_PATH should do the trick.
  • Mention all the LD_PRELOAD problem, at least pointing to some exhaustive documentation on how to deal with it (see Clearly document the MATLAB PRELOAD problem #64).
@gabrielenava
Copy link
Collaborator

Clarify how the CMake subprojects of the superbuild are actually finding Matlab. In particular, if the robotology is not able to find Matlab, the user has no guidance on how to setup its system to make sure that matlab is found. As of CMake 3.10 the FindMatlab.cmake is not checking any env variable such as Matlab_ROOT_DIR or MATLAB_DIR, the only reliable way to get CMake to detect matlab is to ensure that this call to find_program is able to find the matlab program: https://github.com/Kitware/CMake/blob/v3.10.2/Modules/FindMatlab.cmake#L1035 . To make sure that find_program finds matlab, it is possible to check the search policy of find_program in CMake's docs : https://cmake.org/cmake/help/v3.8/command/find_program.html?highlight=i . In particular, adding (at least temporary) the directory in which matlab is contained in PATH or CMAKE_PROGRAM_PATH should do the trick.

I think this has been done, am I right? At, lest, it seems so by looking at https://github.com/robotology/robotology-superbuild#system-dependencies-8

Mention all the LD_PRELOAD problem, at least pointing to some exhaustive documentation on how to deal with it (see #64).

concerning this, there is the link to the WBToolbox README. See https://github.com/robotology/robotology-superbuild#start-matlab-from-the-terminal

@traversaro do you think that what this is enough to close the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants