FirmwareUpdater - ERROR message on successful FW flashing.

[davidetome]

Bug description

When you do Upload Application, the message in the terminal at the end of the programming returns a failed operation even if it went well.

EthMaintainer::cmdProgram() is about to program the APP partition of 1 boards: 10.0.1.1 (candoit)
ERROR: EthMaintainer::program() could not program board none @ 0.0.0.0: 10.0.1.1: APP NOK

Steps to reproduce

• Open Firmware Updater
• Do a discover
• Select an ETH board, an mc4plus (in my case)
• Put the board un Maintenance
• Do Upload Application
• See the FAIL message in the terminal

Expected behavior

The message should report a successful operation (APP OK)

Example repository

No response

Additional context

No response

[davidetome]

cc @valegagge

[davidetome]

I found the reason of the failure, in the command_program method because two indexes differ by one

I also noticed that one of them is increased by one just after it is initialized at zero

Commenting out it, the program operation works properly :

I have to double-check if it is ok to comment out this line 👍🏼

There's also an issue with variables that are not filled in the message

cc @valegagge

[davidetome]

I tested the mod w/ 2 mc4plus and one ems and it works properly 👍🏼

2 mc4plus programmed in parallel successfully

1 ems programmed successfully

Now I'm going to fix the message :

OK: EthMaintainer::program() has succesfully programmed board none @ 0.0.0.0.

cc @valegagge

[davidetome]

Fixed message

With this commit in my fork I fixed also the message in the terminal :

2 mc4plus programmed in parallel successfully

1 ems programmed successfully

@valegagge I wait for your green light 🚦 to rebase and open the PR 👍🏼

[davidetome]

PR opened :

• FirmwareUpdater - fix programming ETH board result and message #944

cc @valegagge

[pattacini]

Hi @davidetome

The issue will be closed upon merging the PR.

[pattacini]

PR merged ✅