-
-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build Improvements for Packaging #2013
Comments
Amazing!! <3 Thanks a lot for this, it's much appreciated. I will work through the rest of your report to find the best solution. |
Nice catch, I think indeed I should replace |
That makes sense. Maybe a |
Same for this. We should probably just use |
From the top of my head I think I did it that way because I couldn't find the .pc files, but I could be wrong as well and I could have just missed those files. The safest approach is probably to use the dependency + find_library fallback approach for both libs. |
|
@carlocab is it ok if we reference homebrew in our INSTALL section as a way to install Rizin on Mac after the formula will be mergd? |
Of course; that's more than okay. :) |
Thanks! |
@carlocab the fix is now included in the 0.3.3 release: https://github.com/rizinorg/rizin/releases/tag/v0.3.3 |
Yep, I noticed. Thanks for the update! |
Is your feature request related to a problem? Please describe.
@ebmmy was kind enough to work on packaging Rizin for Homebrew. See Homebrew/homebrew-core#89709.
While trying to get the build to pass in Homebrew CI, we encountered issues in
meson
being able to find Homebrewxxhash
andlibmagic
.libmagic
is found via Meson'sfind_library
. Unfortunately,find_library
doesn't seem to know how to find Homebrew-installed libraries by default, so we worked around this by adding adirs
argument to thefind_library
call.xxhash
is found using Meson'sdependency
, which usespkg-config
. Unfortunately,pkg-config
looks for anxxhash.pc
, but a defaultxxhash
build installs onlylibxxhash.pc
. We worked around this by creating a symlink, but it would be nice if this were not needed.Describe the solution you'd like
For
libmagic
, it might help if there were additional options inmeson_options.txt
that allow passing the path to the directory containinglibmagic
, which is then passed to thedirs
argument offind_library
. This would allow us to pass this as a flag tomeson
rather than modifying your build script (which can be a bit fragile).I'm not sure if a similar fix would work for
xxhash
, but sincemeson.build
seems to fall back tofind_library
whendependency
doesn't work, this might too.Describe alternatives you've considered
We could keep carrying around our workarounds, but it would be nice if we didn't have to. Finding fixes here would also ensure that your users who encounter the same problems we did (outside of Homebrew) wouldn't have to discover our workarounds for themselves.
Additional context
As mentioned above, this is related to Homebrew/homebrew-core#89709.
The text was updated successfully, but these errors were encountered: