Ensure std::exp can be found after including <cmath> #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As noted in rime#462, including <cmath> only guarantees that std::exp is declared, so calling exp(double) unqualified is not portable. This adds a using-declaration for std::exp so that unqualified calls are guaranteed to work.
lotem
added a commit
that referenced
this pull request
Jan 15, 2022
As noted in #462, including <cmath> only guarantees that std::exp is declared, so calling exp(double) unqualified is not portable. Squashed commit with a style change to the original PR: commit 8b9d48c0340f3fb82de59a6f7ec71ddfd86a602f Author: Chen Gong <chen.sst@gmail.com> Date: Sun Jan 16 00:49:47 2022 +0800 commit df4fe3e Author: Jonathan Wakely <jwakely@redhat.com> Date: Tue Aug 10 10:18:38 2021 +0100 Closes #476
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #462, including
<cmath>only guarantees thatstd::expisdeclared, so calling
exp(double)unqualified is not portable. This addsa using-declaration for
std::expso that unqualified calls areguaranteed to work.