Skip to content

Commit

Permalink
fix(rime_api.cc): using unchecked fields introduced an ABI breakage
Browse files Browse the repository at this point in the history
  • Loading branch information
lotem committed Dec 23, 2019
1 parent 90839b0 commit 62bbead
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion src/rime_api.cc
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,11 @@ RIME_API void RimeSetup(RimeTraits *traits) {

setup_deployer(traits);
if (PROVIDED(traits, app_name)) {
SetupLogging(traits->app_name, traits->min_log_level, traits->log_dir);
if (PROVIDED(traits, min_log_level) && PROVIDED(traits, log_dir)) {
SetupLogging(traits->app_name, traits->min_log_level, traits->log_dir);
} else {
SetupLogging(traits->app_name);
}
}
}

Expand Down

0 comments on commit 62bbead

Please sign in to comment.