Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impl. transpose matvec, matmul #107

Closed
t-hishinuma opened this issue Dec 30, 2021 · 2 comments
Closed

impl. transpose matvec, matmul #107

t-hishinuma opened this issue Dec 30, 2021 · 2 comments
Milestone

Comments

@t-hishinuma
Copy link
Contributor

I want to give modern and intuitive transposition information. But I have no idea how to implement it easily.

First, we create the following function as a prototype

matmul(A,B,C) // C=AB
matmul_TNN(A, B, C); // C=A^TB
matvec(A,x,y); // y = Ax
matvec_T(A, x, y); // y=A^Tx

This interface is not beautiful. However, it has the following advantages

  • It does not affect other functions.
  • Easy to trace with logger
  • Simple to implement FFI in the future.
  • When beautiful ideas appear in the future, these functions can be implemented wrapping it.
@t-hishinuma t-hishinuma added this to the 0.15.3 milestone Dec 30, 2021
@t-hishinuma t-hishinuma removed this from the 0.15.3 milestone Jan 12, 2022
@t-hishinuma
Copy link
Contributor Author

t-hishinuma commented Mar 9, 2022

matmul_TNN(A, B, C); // C=A^TB

Transpose C is not implemented.
Therefore, change as follows.

matmul_TN(A, B, C); // C=A^T B^N

@t-hishinuma
Copy link
Contributor Author

cusparse SpMM has bug? It need to take a lot of time..

I impl. GEMV and SpMV at 0.16.0
I impl. GEMM and SpMM at 0.16.1

this isssue is separlated: #115 #114

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant