Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

continuation-local-storage errors #82

Closed
rstacruz opened this issue Jan 12, 2016 · 4 comments
Closed

continuation-local-storage errors #82

rstacruz opened this issue Jan 12, 2016 · 4 comments

Comments

@rstacruz
Copy link

Using request-promise, I get these npm warnings:

npm ERR! peer invalid: continuation-local-storage@~3, required by cls-bluebird@1.0.1

This warning is preventing me from doing npm shrinkwrap. What is continuation-local-storage and why is it necessary for request-promise to work? and if it's a peerDependency of one of request-promise's dependencies, why isn't it a dependency here?

@analog-nico
Copy link
Member

Hi @rstacruz see pull request #75 . I will take care of that in a few days.

@analog-nico
Copy link
Member

Thanks @rstacruz for reminding me of that issue. It was known far too long and about time to fix it! I just released request-promise@2.0.0 which fixes that.

@analog-nico
Copy link
Member

Hi @rstacruz , I just released request-promise@4.0.0 which dropped the continuation-local-storage and cls-bluebird altogether. Maybe you can remove any workarounds now which you still have in place.

@rstacruz
Copy link
Author

Neat!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants