Mock HTTP calls in specs

[dometto]

Getting this error on Travis, but not locally:

     Failure/Error: logger.error(message) if ::RubyDeps.enable_logging

A bit puzzled as this happens in spec_helper.rb:

load File.expand_path('../../lib/app.rb', __FILE__)
RubyDeps.set(:enable_logging, false)

Have fixed it temporarily by adding defined?(::RubyDeps) condition to the logger methods.

Additionally, I just noticed that the spec files are themselves being covered by simplecov:

Seems like the RSpec environment is being set up quite right, but don't know what the issue is. 😕

[dometto]

Also, the specs are now actually doing HTTP queries. Does that make sense, or should we mock those?

[bartkamphorst]

the specs are now actually doing HTTP queries

Those should be mocked for sure.

[bartkamphorst]

The issues with SimpleCov should be fixable by adding a .simplecov config file, and perhaps explicitly adding filters to exclude _spec.rb files. See simplecov-ruby/simplecov#340 .

[dometto]

Thanks for the pointer! SimpleCov now working locally, and got CoverAlls to work on Travis. Leaving this issue open as a reminder to mock the HTTP calls.