Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove react-is/isValidElementType from production builds #1069

Merged

Conversation

alexreardon
Copy link
Contributor

This is a proposal to only run the code for checking whether an element is valid in non-production builds.

By implementing this change, bundlers can tree shake out react-is altogether for production builds 👍

I think this is fine to be a development only check

@netlify
Copy link

netlify bot commented Oct 31, 2018

Deploy preview for react-redux-docs ready!

Built with commit 07ffa73

https://deploy-preview-1069--react-redux-docs.netlify.com

@alexreardon alexreardon changed the title only running isValidElementType in development builds remove react-is/isValidElementType from production builds Oct 31, 2018
@markerikson
Copy link
Contributor

Seems potentially reasonable. @timdorr , thoughts?

@alexreardon
Copy link
Contributor Author

Given this is a setup issue, I think a development check is appropriate

@timdorr
Copy link
Member

timdorr commented Nov 1, 2018

Yep, seems like a good idea to me.

@timdorr timdorr merged commit 0e44ad1 into reduxjs:master Nov 1, 2018
@alexreardon
Copy link
Contributor Author

alexreardon commented Nov 1, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants