From 9ded5edd5752f4c00222926ae7a0400a564cc992 Mon Sep 17 00:00:00 2001 From: Rob Blafford Date: Fri, 7 Apr 2023 15:50:33 -0400 Subject: [PATCH] kafka/s: Fix unclean restart between reset calls - Not calling `co_await` on mutex::get_units means no lock is actually held. - Fixes: #9647 --- src/v/kafka/server/usage_manager.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/v/kafka/server/usage_manager.cc b/src/v/kafka/server/usage_manager.cc index 494d4308b481..3b6eed3105fd 100644 --- a/src/v/kafka/server/usage_manager.cc +++ b/src/v/kafka/server/usage_manager.cc @@ -367,7 +367,7 @@ ss::future<> usage_manager::reset() { oncore_debug_verify(_verify_shard); try { auto h = _background_gate.hold(); - auto u = _background_mutex.get_units(); + auto u = co_await _background_mutex.get_units(); if (_accounting_fiber) { /// Deallocate the accounting_fiber if the feature is disabled, /// otherwise it will keep in memory the number of configured