From 04e041e399d669026f3dd1903c2b1cf89ff8864e Mon Sep 17 00:00:00 2001 From: Alexey Zatelepin Date: Fri, 28 Oct 2022 01:59:40 +0300 Subject: [PATCH] c/partition_balancer: early return in planner main func --- src/v/cluster/partition_balancer_planner.cc | 23 ++++++++++++--------- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/src/v/cluster/partition_balancer_planner.cc b/src/v/cluster/partition_balancer_planner.cc index 8a358425fa39..ee110775d596 100644 --- a/src/v/cluster/partition_balancer_planner.cc +++ b/src/v/cluster/partition_balancer_planner.cc @@ -720,19 +720,22 @@ partition_balancer_planner::plan_reassignments( } if ( - !result.violations.is_empty() - || !_state.ntps_with_broken_rack_constraint().empty()) { - init_ntp_sizes_from_health_report(health_report, rrs); - get_unavailable_nodes_reassignments(result, rrs); - get_rack_constraint_repair_reassignments(result, rrs); - get_full_node_reassignments(result, rrs); - if (!result.reassignments.empty()) { - result.status = status::movement_planned; - } - + result.violations.is_empty() + && _state.ntps_with_broken_rack_constraint().empty()) { + result.status = status::empty; return result; } + init_ntp_sizes_from_health_report(health_report, rrs); + + get_unavailable_nodes_reassignments(result, rrs); + get_rack_constraint_repair_reassignments(result, rrs); + get_full_node_reassignments(result, rrs); + + if (!result.reassignments.empty()) { + result.status = status::movement_planned; + } + return result; }