Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type hints for JSON commands #1921

Merged
merged 10 commits into from
Feb 6, 2022
Merged

Add type hints for JSON commands #1921

merged 10 commits into from
Feb 6, 2022

Conversation

dvora-h
Copy link
Collaborator

@dvora-h dvora-h commented Feb 2, 2022

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Please provide a description of the change here.

@dvora-h dvora-h added the feature New feature label Feb 2, 2022
@dvora-h dvora-h requested a review from chayim February 2, 2022 09:10
"""Return the memory usage in bytes of a value under ``path`` from
key ``name``.

For more information: https://oss.redis.com/redisjson/commands/#jsondebg
For more information: https://oss.redis.com/redisjson/commands/#jsondebug
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch!

dvora-h and others added 9 commits February 2, 2022 17:21
* add bzmpop

* add comment

* fix pr comment

* fix linters

* fix pr comments
* add zintercard

* fix pr comment

* linters
* add sort_ro

* mark test as onlynon cluster

* delete mark test as onlynoncluster

* add eval_ro

* fix linters

* delete sort_ro

* fix pr comment

* add type hints

* add type hints

* linters
* add evalsha-ro

* fix pr comment

* add type hints

* add type hints
* fix naming convention

* fix worng changes
@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2022

Codecov Report

Merging #1921 (ef899db) into master (4d7de6d) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1921      +/-   ##
==========================================
+ Coverage   92.99%   93.01%   +0.01%     
==========================================
  Files          76       77       +1     
  Lines       16537    16541       +4     
==========================================
+ Hits        15379    15385       +6     
+ Misses       1158     1156       -2     
Impacted Files Coverage Δ
redis/commands/json/_util.py 100.00% <100.00%> (ø)
redis/commands/json/commands.py 89.07% <100.00%> (+0.18%) ⬆️
tests/test_cluster.py 98.28% <0.00%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d7de6d...ef899db. Read the comment docs.

@dvora-h dvora-h requested a review from chayim February 3, 2022 10:45
@dvora-h dvora-h merged commit 30be3a3 into redis:master Feb 6, 2022
@dvora-h dvora-h deleted the json-t-h branch February 6, 2022 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants