Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perf: after creating connection enable tcp_nodelay #405

Closed
AVVS opened this issue Dec 2, 2016 · 6 comments
Closed

Perf: after creating connection enable tcp_nodelay #405

AVVS opened this issue Dec 2, 2016 · 6 comments

Comments

@AVVS
Copy link
Collaborator

AVVS commented Dec 2, 2016

As in put stream.setNoDelay() on the socket
Will decrease latency in most cases
@luin luin mentioned this issue Dec 2, 2016
Merged
@luin
Copy link
Collaborator

luin commented Dec 2, 2016

Thank you for addressing that! I've added you as the contributor, please review & merge the pull request above.

@AVVS
Copy link
Collaborator Author

AVVS commented Dec 2, 2016

Thanks, will do

@AVVS
Copy link
Collaborator Author

AVVS commented Dec 2, 2016

Closed by #406

@AVVS AVVS closed this as completed Dec 2, 2016
@AVVS
Copy link
Collaborator Author

AVVS commented Dec 2, 2016 •
edited
Loading

We also might want to add to the docs that if somebody does bulk export/import and its important to increase throughput, whereas latency doesn't matter as much - noDelay should be set to false, because while this decreases latency, it reduces maximum throughput

@AVVS
Copy link
Collaborator Author

AVVS commented Dec 3, 2016

@luin can you release the latest version?

@luin
Copy link
Collaborator

luin commented Dec 4, 2016

v2.4.1 released. 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@luin @AVVS