Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

we support redis cluster for hiredis #366

Closed
deep011 opened this issue Sep 30, 2015 · 7 comments
Closed

we support redis cluster for hiredis #366

deep011 opened this issue Sep 30, 2015 · 7 comments
Assignees
Labels

Comments

@deep011
Copy link

deep011 commented Sep 30, 2015

@badboy
Hi, we support redis cluster for hiredis that based on hiredis-0.13.1.
Can you help me review it and will i can pull request for this?

github: https://github.com/vipshop/hiredis-vip
some examples: https://github.com/vipshop/hiredis-vip/wiki

think you very much!

@badboy badboy self-assigned this Oct 2, 2015
@tennessine
Copy link

@deep011 正需要

@arr2036
Copy link

arr2036 commented Oct 27, 2015

There's absolutely no reason to include cluster support in hiredis. As one of the maintainers said, it should be implemented on top of hiredis. That could be a separate library, or it could be implemented by the application.

@badboy
Copy link
Contributor

badboy commented Oct 27, 2015

It's still good to know about the project and I will take a look at it when I've got time.

@arr2036
Copy link

arr2036 commented Oct 27, 2015

If it does get merged, can it please be built as a separate library, so there's a clean distinction between the code that deals with the protocol, and the code that deals with representing the state of the cluster.

@badboy
Copy link
Contributor

badboy commented Oct 27, 2015

I'm not even talking about merging yet ;)

@tennessine
Copy link

@deep011 hiredis不会断线重连 咋办呢 我是phper 不是很会写c 求帮助

@deep011
Copy link
Author

deep011 commented Nov 4, 2015

@w3hacker ,Please give your code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants