Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TimeSeries Create function always creates the TS as "uncompressed" when specifying true or false to the function argument #319

Closed
Auttcast opened this issue Jul 4, 2024 · 1 comment · Fixed by #329
Assignees
Labels
bug Something isn't working

Comments

@Auttcast
Copy link

Auttcast commented Jul 4, 2024

NRedisStack Version: 0.12.0

Description:

Expected:
I'm calling the TS create function with the uncompressed argument set to false, expecting that it should create the TS with compression enabled.

Actual:
The TS is still created as uncompressed.

Notes:
In debugging with redis MONITOR I can see that specifying true or false still issues a TS.CREATE with the UNCOMPRESSED parameter set.

It looks like the problem is with this function in TimeSeriesParamsBuilder where it is setting the UNCOMPRESSED option entirely based on the presence of the arg regardless of it's value.
https://github.com/redis/NRedisStack/blob/master/src/NRedisStack/TimeSeries/TimeSeriesParamsBuilder.cs#L109

Workaround:
Set the uncompressed argument to null

@uglide uglide added the bug Something isn't working label Aug 7, 2024
@uglide
Copy link
Contributor

uglide commented Aug 7, 2024

Hello @Auttcast

Thanks for the bug report. We will address it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants