Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F2 rename of Lombok @Singular attribute does nothing #3203

Closed
richlanders opened this issue Jul 16, 2023 · 2 comments · Fixed by eclipse-jdtls/eclipse.jdt.ls#2828
Closed
Assignees
Labels

Comments

@richlanders
Copy link

In a class with Lombok @builder, F2 rename of a List attribute annotated with @Singular does nothing.
Rename a List attribute without @Singular works fine.

Environment
  • Operating System: MacOS Ventura 13.2.1 (22D68)
  • JDK version: OpenJDK 64-Bit Server VM Temurin-11.0.17+8 (build 11.0.17+8, mixed mode)
  • Visual Studio Code version: Version: 1.80.1 (Universal) Commit: 74f6148eb9ea00507ec113ec51c489d6ff
  • Java extension version: 1.20.0 (June 29th, 2023)
Steps To Reproduce
  1. With a DTO with @builder and @getterS and a List attribute "singulars" marked up with @Singular and
  2. ...code elsewhere that uses the "singulars" attribute:
  3. Highlight the attribute name "singulars" and hit F2 (rename)
  4. Use the dialog to rename the attribute "singulars2"
  5. Result: Dialog closes without error but seemingly no action is taken.
Project

lombok-bug.zip

Logs

java-language-server-output.log.zip

Current Result

Dialog closes and attribute "singulars" name is not changed.

Expected Result

Dialog closes and attribute "singulars" renamed to "singulars2" everywhere.

Additional Information

NOTE: F2 rename works fine from any usage of the attribute "singulars".

@snjeza snjeza self-assigned this Aug 30, 2023
@snjeza
Copy link
Contributor

snjeza commented Aug 30, 2023

This is an upstream Eclipse or Lombok issue. I can reproduce it in eclipse.

@richlanders
Copy link
Author

Thank you all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants