From 0dd1a43904e7d12c76e810b1bbd87d99a0f835c3 Mon Sep 17 00:00:00 2001
From: Tomas Votruba <tomas.vot@gmail.com>
Date: Thu, 21 Mar 2024 12:34:15 +0100
Subject: [PATCH] [DeadCode] Add new rule - ReduceAlwaysFalseIfOrRector (#5750)

* [DeadCode] Add ReduceAlwaysFalseIfOrRector

* add to dead-code ruleset
---
 .../Fixture/some_class.php.inc                | 35 ++++++++
 .../ReduceAlwaysFalseIfOrRectorTest.php       | 28 ++++++
 .../config/configured_rule.php                | 10 +++
 .../If_/ReduceAlwaysFalseIfOrRector.php       | 88 +++++++++++++++++++
 src/Config/Level/DeadCodeLevel.php            |  2 +
 5 files changed, 163 insertions(+)
 create mode 100644 rules-tests/DeadCode/Rector/If_/ReduceAlwaysFalseIfOrRector/Fixture/some_class.php.inc
 create mode 100644 rules-tests/DeadCode/Rector/If_/ReduceAlwaysFalseIfOrRector/ReduceAlwaysFalseIfOrRectorTest.php
 create mode 100644 rules-tests/DeadCode/Rector/If_/ReduceAlwaysFalseIfOrRector/config/configured_rule.php
 create mode 100644 rules/DeadCode/Rector/If_/ReduceAlwaysFalseIfOrRector.php

diff --git a/rules-tests/DeadCode/Rector/If_/ReduceAlwaysFalseIfOrRector/Fixture/some_class.php.inc b/rules-tests/DeadCode/Rector/If_/ReduceAlwaysFalseIfOrRector/Fixture/some_class.php.inc
new file mode 100644
index 00000000000..583691319c7
--- /dev/null
+++ b/rules-tests/DeadCode/Rector/If_/ReduceAlwaysFalseIfOrRector/Fixture/some_class.php.inc
@@ -0,0 +1,35 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\If_\ReduceAlwaysFalseIfOrRector\Fixture;
+
+class SomeClass
+{
+    public function run(int $number)
+    {
+        if (! is_int($number) || $number > 50) {
+            return 'yes';
+        }
+
+        return 'no';
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\If_\ReduceAlwaysFalseIfOrRector\Fixture;
+
+class SomeClass
+{
+    public function run(int $number)
+    {
+        if ($number > 50) {
+            return 'yes';
+        }
+
+        return 'no';
+    }
+}
+
+?>
diff --git a/rules-tests/DeadCode/Rector/If_/ReduceAlwaysFalseIfOrRector/ReduceAlwaysFalseIfOrRectorTest.php b/rules-tests/DeadCode/Rector/If_/ReduceAlwaysFalseIfOrRector/ReduceAlwaysFalseIfOrRectorTest.php
new file mode 100644
index 00000000000..b3350c9a97e
--- /dev/null
+++ b/rules-tests/DeadCode/Rector/If_/ReduceAlwaysFalseIfOrRector/ReduceAlwaysFalseIfOrRectorTest.php
@@ -0,0 +1,28 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\DeadCode\Rector\If_\ReduceAlwaysFalseIfOrRector;
+
+use Iterator;
+use PHPUnit\Framework\Attributes\DataProvider;
+use Rector\Testing\PHPUnit\AbstractRectorTestCase;
+
+final class ReduceAlwaysFalseIfOrRectorTest extends AbstractRectorTestCase
+{
+    #[DataProvider('provideData')]
+    public function test(string $filePath): void
+    {
+        $this->doTestFile($filePath);
+    }
+
+    public static function provideData(): Iterator
+    {
+        return self::yieldFilesFromDirectory(__DIR__ . '/Fixture');
+    }
+
+    public function provideConfigFilePath(): string
+    {
+        return __DIR__ . '/config/configured_rule.php';
+    }
+}
diff --git a/rules-tests/DeadCode/Rector/If_/ReduceAlwaysFalseIfOrRector/config/configured_rule.php b/rules-tests/DeadCode/Rector/If_/ReduceAlwaysFalseIfOrRector/config/configured_rule.php
new file mode 100644
index 00000000000..52cfb81d996
--- /dev/null
+++ b/rules-tests/DeadCode/Rector/If_/ReduceAlwaysFalseIfOrRector/config/configured_rule.php
@@ -0,0 +1,10 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\Config\RectorConfig;
+use Rector\DeadCode\Rector\If_\ReduceAlwaysFalseIfOrRector;
+
+return static function (RectorConfig $rectorConfig): void {
+    $rectorConfig->rule(ReduceAlwaysFalseIfOrRector::class);
+};
diff --git a/rules/DeadCode/Rector/If_/ReduceAlwaysFalseIfOrRector.php b/rules/DeadCode/Rector/If_/ReduceAlwaysFalseIfOrRector.php
new file mode 100644
index 00000000000..565563b11b9
--- /dev/null
+++ b/rules/DeadCode/Rector/If_/ReduceAlwaysFalseIfOrRector.php
@@ -0,0 +1,88 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\DeadCode\Rector\If_;
+
+use PhpParser\Node;
+use PhpParser\Node\Expr\BinaryOp\BooleanOr;
+use PhpParser\Node\Stmt\If_;
+use PHPStan\Type\Constant\ConstantBooleanType;
+use Rector\Rector\AbstractRector;
+use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
+use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
+
+/**
+ * @see \Rector\Tests\DeadCode\Rector\If_\ReduceAlwaysFalseIfOrRector\ReduceAlwaysFalseIfOrRectorTest
+ */
+final class ReduceAlwaysFalseIfOrRector extends AbstractRector
+{
+    public function getRuleDefinition(): RuleDefinition
+    {
+        return new RuleDefinition('Reduce always false in a if ( || ) condition', [
+            new CodeSample(
+                <<<'CODE_SAMPLE'
+class SomeClass
+{
+    public function run(int $number)
+    {
+        if (! is_int($number) || $number > 50) {
+            return 'yes';
+        }
+
+        return 'no';
+    }
+}
+CODE_SAMPLE
+
+                ,
+                <<<'CODE_SAMPLE'
+class SomeClass
+{
+    public function run(int $number)
+    {
+        if ($number > 50) {
+            return 'yes';
+        }
+
+        return 'no';
+    }
+}
+CODE_SAMPLE
+            ),
+        ]);
+    }
+
+    /**
+     * @return array<class-string<Node>>
+     */
+    public function getNodeTypes(): array
+    {
+        return [If_::class];
+    }
+
+    /**
+     * @param If_ $node
+     */
+    public function refactor(Node $node): ?Node
+    {
+        if (! $node->cond instanceof BooleanOr) {
+            return null;
+        }
+
+        $booleanOr = $node->cond;
+
+        $conditionStaticType = $this->getType($booleanOr->left);
+        if (! $conditionStaticType instanceof ConstantBooleanType) {
+            return null;
+        }
+
+        if ($conditionStaticType->getValue()) {
+            return null;
+        }
+
+        $node->cond = $booleanOr->right;
+
+        return $node;
+    }
+}
diff --git a/src/Config/Level/DeadCodeLevel.php b/src/Config/Level/DeadCodeLevel.php
index 203abc1c72e..7e3ca367ec2 100644
--- a/src/Config/Level/DeadCodeLevel.php
+++ b/src/Config/Level/DeadCodeLevel.php
@@ -29,6 +29,7 @@
 use Rector\DeadCode\Rector\For_\RemoveDeadLoopRector;
 use Rector\DeadCode\Rector\Foreach_\RemoveUnusedForeachKeyRector;
 use Rector\DeadCode\Rector\FunctionLike\RemoveDeadReturnRector;
+use Rector\DeadCode\Rector\If_\ReduceAlwaysFalseIfOrRector;
 use Rector\DeadCode\Rector\If_\RemoveAlwaysTrueIfConditionRector;
 use Rector\DeadCode\Rector\If_\RemoveDeadInstanceOfRector;
 use Rector\DeadCode\Rector\If_\RemoveTypedPropertyDeadInstanceOfRector;
@@ -94,6 +95,7 @@ final class DeadCodeLevel
         RemovePhpVersionIdCheckRector::class,
 
         RemoveAlwaysTrueIfConditionRector::class,
+        ReduceAlwaysFalseIfOrRector::class,
         RemoveUnusedPrivateClassConstantRector::class,
         RemoveUnusedPrivatePropertyRector::class,