Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [Feature request]: Automate the process to check and fix lint issues #1138

Closed
1 task done
supminn opened this issue Apr 27, 2023 · 9 comments · Fixed by #1241
Closed
1 task done

✨ [Feature request]: Automate the process to check and fix lint issues #1138

supminn opened this issue Apr 27, 2023 · 9 comments · Fixed by #1241
Assignees
Labels
good first issue New-contributor friendly

Comments

@supminn
Copy link
Contributor

supminn commented Apr 27, 2023

Is your feature request related to a problem? Please describe.

Whenever any new changes are made to the ReactPlay repository, we need to manually run the yarn lint to check for any lint errors and fix them accordingly. Failing to ensure this would cause failure in the overall project build.

Describe the solution you'd like.

We need to implement a pre-commit logic that would test for lint issues when a user is adding a new commit to this repository.

Describe alternatives you've considered.

One possible solution could be using husky

Screenshot / Screenshare

No response

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@github-actions
Copy link

Hey! contributor, thank you for opening an Issue 🎉.

@reactplay/maintainers will review your submission soon and give you helpful feedback. If you're interested in continuing your contributions to open source and want to be a part of a welcoming and fantastic community, we invite you to join our ReactPlay Discord Community.
Show your support by starring ⭐ this repository. Thank you and we appreciate your contribution to open source!
Stale Marking : After 30 days of inactivity this issue/PR will be marked as stale issue/PR and it will be closed and locked in 7 days if no further activity occurs.

@supminn supminn added the good first issue New-contributor friendly label Apr 27, 2023
@Harsh-Daga
Copy link

Harsh-Daga commented Apr 29, 2023

Heyy,
If no one is working on this currently, can I work on this ?

@Sachin-chaurasiya
Copy link
Member

Heyy, If no one is working on this currently, can I work on this ?

Hello @Harsh-Daga , thanks for showing interest, I'm assigning this issue to you.

@github-actions
Copy link

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale. Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a 👍 Because this issue is marked as stale, it will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions!

@github-actions github-actions bot added the stale label May 30, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 7, 2023
@atapas atapas removed the stale label Jun 7, 2023
@atapas atapas reopened this Jun 7, 2023
@shyamtawli
Copy link
Contributor

Can I work on it.

@atapas
Copy link
Member

atapas commented Jun 18, 2023

@supminn what about the existing PR?

@supminn
Copy link
Contributor Author

supminn commented Jun 19, 2023

@supminn what about the existing PR?

The PR is ready for merge. However, I was not sure on how to test it.

@shyamtawli
Copy link
Contributor

@supminn what about the existing PR?

The PR is ready for merge. However, I was not sure on how to test it.

It can be tested at the time of commit I guess?

@github-actions
Copy link

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale. Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a 👍 Because this issue is marked as stale, it will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions!

@github-actions github-actions bot added the stale label Jul 21, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 29, 2023
@atapas atapas reopened this Sep 7, 2023
@atapas atapas removed the stale label Sep 7, 2023
@supminn supminn assigned supminn and unassigned Harsh-Daga Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue New-contributor friendly
Projects
None yet
5 participants