Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 Peer Dependencies do not support Storybook 6 and React 17 #8

Open
siiiiilvio opened this issue Apr 6, 2021 · 1 comment
Open
Labels

Comments

@siiiiilvio
Copy link
Contributor

I've been using your package with Storybook 6 and React 17 with no issues. However NPM 7 will not allow installation without passing the --force or --legacy-peer-depsflag because of these missing Peer Dependencies.

@CWSites
Copy link

CWSites commented Oct 27, 2021

Over 6 months, still not addressed.

warning "@react-theming/storybook-addon > @storybook/addon-devkit@1.4.1" has incorrect peer dependency "@storybook/addons@^5.0.0".
warning "@react-theming/storybook-addon > @storybook/addon-devkit@1.4.1" has incorrect peer dependency "@storybook/react@^5.0.0".
warning "@react-theming/storybook-addon > @storybook/addon-devkit@1.4.1" has incorrect peer dependency "react@^16.0.0".
warning "@react-theming/storybook-addon > @storybook/addon-devkit@1.4.1" has incorrect peer dependency "react-dom@^16.0.0".

In addition, @reach/react@0.2.1 needs to be upgraded to 0.16.0 which will handle the following warnings.

warning "@react-theming/storybook-addon > @storybook/addon-devkit > @reach/rect@0.2.1" has incorrect peer dependency "react@^16.8.0".
warning "@react-theming/storybook-addon > @storybook/addon-devkit > @reach/rect@0.2.1" has incorrect peer dependency "react-dom@^16.8.0".

Also here, a version of @reach/rect isn't specified so it's being loaded twice.

warning "@react-theming/storybook-addon > @storybook/addon-devkit > @reach/rect > @reach/component-component@0.1.3" has incorrect peer dependency "react@^16.4.0".
warning "@react-theming/storybook-addon > @storybook/addon-devkit > @reach/rect > @reach/component-component@0.1.3" has incorrect peer dependency "react-dom@^16.4.0".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants