Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SetSepakerPhone android bug fix #201

Merged
merged 2 commits into from
Dec 5, 2022

Conversation

Azamatjon
Copy link
Contributor

SetSepakerPhone android bug fix
Related with #164 (comment) and tested with android device

@zxcpoiu
Copy link
Member

zxcpoiu commented Dec 5, 2022

Thanks for pointing out the discussion.

I see your point. we have start() function and set the audio mode to MODE_IN_COMMUNICATION, but somehow for some use case, uses the setSpeakerPhoneOn without start, the the audio mode does not change to the MODE_IN_COMMUNICATION

This module is focus on talking, so we have defaultAudioMode = AudioManager.MODE_IN_COMMUNICATION already.
So I change the way and the execution place to use the defaultAudioMode

For future folks, if you did not use start() first but use other functions and encounter some thing like echo, remember to set the desired audioMode yourself based on your audio case.

@zxcpoiu zxcpoiu merged commit 7ef0132 into react-native-webrtc:master Dec 5, 2022
tatthangcntt added a commit to brekekesoftware/react-native-incall-manager that referenced this pull request Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants