refactor: enter will trigger onChange (#357)

react-component · Sep 16, 2021 · 2166c92 · 2166c92 · vercel · Sep 16, 2021
1 parent c4ae6f8
commit 2166c92
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/src/InputNumber.tsx b/src/InputNumber.tsx
@@ -428,7 +428,7 @@ const InputNumber = React.forwardRef(
         if (!compositionRef.current) {
           userTypingRef.current = false;
         }
-        flushInputValue(true);
+        flushInputValue(false);
         onPressEnter?.(event);
       }
 

diff --git a/tests/keyboard.test.tsx b/tests/keyboard.test.tsx
@@ -30,4 +30,16 @@ describe('InputNumber.Keyboard', () => {
     wrapper.find('input').simulate('keyDown', { which: KeyCode.DOWN });
     expect(onChange).not.toHaveBeenCalled();
   });
+
+  it('enter to trigger onChange with precision', () => {
+    const onChange = jest.fn();
+    const wrapper = mount(<InputNumber precision={0} onChange={onChange} />);
+
+    wrapper.find('input').simulate('change', { target: { value: '2.3333' } });
+    expect(onChange).toHaveBeenCalledWith(2.3333);
+    onChange.mockReset();
+
+    wrapper.find('input').simulate('keyDown', { which: KeyCode.ENTER });
+    expect(onChange).toHaveBeenCalledWith(2);
+  });
 });