Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support PreviewGroup#items locating when clicking image #344

Merged
merged 5 commits into from
May 15, 2024

Conversation

vagusX
Copy link
Member

@vagusX vagusX commented May 14, 2024

  • 修复 PreviewGroup#items 自定义时,默认定位到第 0 张的问题(因为查找按照自增 id 去查找了,此时应跳过查找)

@vagusX vagusX requested a review from zombieJ May 14, 2024 08:06
Copy link

vercel bot commented May 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
image ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2024 6:41am

Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.78%. Comparing base (66b57c2) to head (c46cdb3).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #344   +/-   ##
=======================================
  Coverage   99.77%   99.78%           
=======================================
  Files          15       15           
  Lines         454      456    +2     
  Branches      125      128    +3     
=======================================
+ Hits          453      455    +2     
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afc163
Copy link
Member

afc163 commented May 14, 2024

你为啥会需要这个?current 不够用么

src/PreviewGroup.tsx Outdated Show resolved Hide resolved
@vagusX
Copy link
Member Author

vagusX commented May 14, 2024

你为啥会需要这个?current 不够用么

就是不够简洁,current 要完全受控才能用,

@vagusX vagusX force-pushed the feat/support-preview-default-current branch from 74eba0a to d2fabfe Compare May 15, 2024 02:38
@vagusX vagusX changed the title feat: support preview#defaultCurrent props fix: support PreviewGroup#items locating when clicking image May 15, 2024
@vagusX vagusX requested a review from zombieJ May 15, 2024 02:56
src/PreviewGroup.tsx Outdated Show resolved Hide resolved
src/PreviewGroup.tsx Outdated Show resolved Hide resolved
@zombieJ zombieJ merged commit 84b7973 into master May 15, 2024
9 checks passed
@zombieJ zombieJ deleted the feat/support-preview-default-current branch May 15, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants