Skip to content

Commit

Permalink
Reset rotation and position on double click (#119)
Browse files Browse the repository at this point in the history
* Reset rotation and position on double click

* add tests

* address comment

* use useCallback

* fix typo

* use img onDoubleClick prop

* remove onDoubleClick from useEffect deps

* fix tests

* fix coverage

* fix tests

* Update src/Preview.tsx

Co-authored-by: afc163 <afc163@gmail.com>

* fix conditions

Signed-off-by: harupy <hkawamura0130@gmail.com>

Co-authored-by: afc163 <afc163@gmail.com>
  • Loading branch information
harupy and afc163 committed Apr 27, 2022
1 parent fd2d0a6 commit bf1150a
Show file tree
Hide file tree
Showing 2 changed files with 96 additions and 25 deletions.
12 changes: 12 additions & 0 deletions src/Preview.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,17 @@ const Preview: React.FC<PreviewProps> = props => {
],
);

const onDoubleClick = () => {
if (visible) {
if (scale !== 1) {
setScale(1);
}
if (position.x !== initialPosition.x || position.y !== initialPosition.y) {
setPosition(initialPosition);
}
}
};

useEffect(() => {
const { wheelDirection } = lastWheelZoomDirection;
if (wheelDirection > 0) {
Expand Down Expand Up @@ -317,6 +328,7 @@ const Preview: React.FC<PreviewProps> = props => {
>
<img
onMouseDown={onMouseDown}
onDoubleClick={onDoubleClick}
ref={imgRef}
className={`${prefixCls}-img`}
src={combinationSrc}
Expand Down
109 changes: 84 additions & 25 deletions tests/preview.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,31 @@ describe('Preview', () => {
jest.useRealTimers();
});

const fireMouseEvent = (
eventName: 'mouseDown' | 'mouseMove' | 'mouseUp',
element: Element | Window,
info: {
pageX?: number;
pageY?: number;
button?: number;
} = {},
) => {
const event = createEvent[eventName](element);
Object.keys(info).forEach(key => {
Object.defineProperty(event, key, {
get: () => info[key],
});
});

act(() => {
fireEvent(element, event);
});

act(() => {
jest.runAllTimers();
});
};

it('Show preview and close', () => {
const onPreviewCloseMock = jest.fn();
const { container } = render(
Expand Down Expand Up @@ -165,6 +190,65 @@ describe('Preview', () => {
});
});

it('Reset scale on double click', () => {
const { container } = render(
<Image src="https://zos.alipayobjects.com/rmsportal/jkjgkEfvpUPVyRjUImniVslZfWPnJuuZ.png" />,
);

fireEvent.click(container.querySelector('.rc-image'));
act(() => {
jest.runAllTimers();
});

fireEvent.click(document.querySelectorAll('.rc-image-preview-operations-operation')[1]);
act(() => {
jest.runAllTimers();
});
expect(document.querySelector('.rc-image-preview-img')).toHaveStyle({
transform: 'scale3d(2, 2, 1) rotate(0deg)',
});

fireEvent.dblClick(document.querySelector('.rc-image-preview-img'));
act(() => {
jest.runAllTimers();
});
expect(document.querySelector('.rc-image-preview-img')).toHaveStyle({
transform: 'scale3d(1, 1, 1) rotate(0deg)',
});
});

it('Reset position on double click', () => {
const { container } = render(
<Image src="https://zos.alipayobjects.com/rmsportal/jkjgkEfvpUPVyRjUImniVslZfWPnJuuZ.png" />,
);

fireEvent.click(container.querySelector('.rc-image'));
act(() => {
jest.runAllTimers();
});

fireMouseEvent('mouseDown', document.querySelector('.rc-image-preview-img'), {
pageX: 0,
pageY: 0,
button: 0,
});
fireMouseEvent('mouseMove', window, {
pageX: 50,
pageY: 50,
});
expect(document.querySelector('.rc-image-preview-img-wrapper')).toHaveStyle({
transform: 'translate3d(50px, 50px, 0)',
});

fireEvent.dblClick(document.querySelector('.rc-image-preview-img'));
act(() => {
jest.runAllTimers();
});
expect(document.querySelector('.rc-image-preview-img-wrapper')).toHaveStyle({
transform: 'translate3d(0px, 0px, 0)',
});
});

it('Mouse Event', () => {
const clientWidthMock = jest
.spyOn(document.documentElement, 'clientWidth', 'get')
Expand All @@ -175,31 +259,6 @@ describe('Preview', () => {
let left = 0;
let top = 0;

const fireMouseEvent = (
eventName: 'mouseDown' | 'mouseMove' | 'mouseUp',
element: Element | Window,
info: {
pageX?: number;
pageY?: number;
button?: number;
} = {},
) => {
const event = createEvent[eventName](element);
Object.keys(info).forEach(key => {
Object.defineProperty(event, key, {
get: () => info[key],
});
});

act(() => {
fireEvent(element, event);
});

act(() => {
jest.runAllTimers();
});
};

const imgEleMock = spyElementPrototypes(HTMLImageElement, {
offsetWidth: {
get: () => offsetWidth,
Expand Down

1 comment on commit bf1150a

@vercel
Copy link

@vercel vercel bot commented on bf1150a Apr 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.