Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable names should be alphanumeric or contain underscores #49

Closed
rcjsuen opened this issue May 23, 2019 · 1 comment
Closed

Variable names should be alphanumeric or contain underscores #49

rcjsuen opened this issue May 23, 2019 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@rcjsuen
Copy link
Owner

rcjsuen commented May 23, 2019

Variable names can only contain alphanumeric or underscore characters

FROM alpine
ENV var value
RUN echo $var:test
FROM alpine
ENV var_ value
RUN echo $var_:test

In the two Dockerfiles above, if we put the cursor in the variable within the RUN instruction, our variable highlighting, renaming, and definition lookup features will not work. This is because the system will think the variable's name is var:test or var_:test instead of simply var and var_.

@rcjsuen rcjsuen added the bug Something isn't working label May 23, 2019
@rcjsuen rcjsuen self-assigned this May 23, 2019
@rcjsuen
Copy link
Owner Author

rcjsuen commented May 23, 2019

This would also affect our hover support because then it means it won't resolve to the correct variable name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant