Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: expose 'DRIVELIST_FILTER_SYSTEM_DRIVES' as a cmake var #534

Closed
MrSmoer opened this issue Jan 11, 2023 · 2 comments · Fixed by #816
Closed

Feature Request: expose 'DRIVELIST_FILTER_SYSTEM_DRIVES' as a cmake var #534

MrSmoer opened this issue Jan 11, 2023 · 2 comments · Fixed by #816

Comments

@MrSmoer
Copy link
Contributor

MrSmoer commented Jan 11, 2023

I personally use rpi-imager with DRIVELIST_FILTER_SYSTEM_DRIVES in config.h set to false, because I need to write to SATA drives, so I was wondering whether it would be beneficial to expose it as a cmake arg.

I already created a commit in my fork, should I open a PR?

What do you think?
Thank you, have a nice day!
@tdewey-rpi
Copy link
Collaborator

Hi @MrSmoer,

Please open a PR. I'd be happy to accept this change, provided it operates in the existing mode by default.

@tdewey-rpi
Copy link
Collaborator

Holding this issue open to tie to the PR.

@MrSmoer MrSmoer mentioned this issue Feb 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Exposing 'DRIVELIST_FILTER_SYSTEM_DRIVES' as a cmake variable MrSmoer/rpi-imager
2 participants
@MrSmoer @tdewey-rpi