Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] Botan build failed with error C2039 #4278

Closed
JonLiu1993 opened this issue Jul 31, 2024 · 1 comment
Closed

[C++] Botan build failed with error C2039 #4278

JonLiu1993 opened this issue Jul 31, 2024 · 1 comment

Comments

@JonLiu1993
Copy link

JonLiu1993 commented Jul 31, 2024

Hello, I'm a member of Microsoft VCPKG, when I built botan:x64-windows in an internal version of Visual Studio, it failed with following errors:

build\include\internal\botan/internal/pcurves_id.h(57): error C2039: 'string': is not a member of 'std'

This issue caused by the STL PR: microsoft/STL#4633, and according to the recommendations of the STL developers, the affected files need to include the Standard header.

I have applied this change in vcpkg by microsoft/vcpkg#40192. Since this VS internal version has not been released yet, I am submitting this issue just to inform you.

@randombit
Copy link
Owner

Thank you for the report. On master this has already been resolved #4250 so I’m closing this as completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants