Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release-1.28] - Don't dump the full SQL payload when SlowSQLThreshold is exceeded #6422

Closed
brandond opened this issue Jul 29, 2024 · 1 comment
Assignees

Comments

@brandond
Copy link
Member

Backport fix for Don't dump the full SQL payload when SlowSQLThreshold is exceeded

@mdrahman-suse
Copy link
Contributor

Validated with RC v1.28.12-rc4+rke2r1

Testing

Steps: #6420 (comment)

Replication

$ rke2 -v
rke2 version v1.28.11+rke2r1 (6b12d7a783238b72da8450fa1b6ec587cebb79ed)
go version go1.21.11 X:boringcrypto

$ sudo journalctl -u rke2-server | grep sqlite
Jul 30 22:16:41 server1 rke2[44632]: time="2024-07-30T22:16:41Z" level=info msg="Configuring sqlite3 database connection pooling: maxIdleConns=2, maxOpenConns=0, connMaxLifetime=0s"

$ sudo journalctl -u rke2-server | grep -i "Slow SQL"
Jul 30 22:18:56 ip-172-31-44-4 rke2[44632]: time="2024-07-30T22:18:56Z" level=info msg="Slow SQL (started: 2024-07-30 22:18:53.57494314 +0000 UTC m=+132.141691033) (total time: 2.936210838s): INSERT INTO kine(name, created, deleted, create_revision, prev_revision, lease, value, old_value) values(?, ?, ?, ?, ?, ?, ?, ?) : [[/registry/masterleases/172.31.44.4 0 0 193 ...

Validation

$ rke2 -v
rke2 version v1.28.12-rc4+rke2r1 (9e861ad70da2c4164f5a2fddf58497365e7172f2)
go version go1.22.5 X:boringcrypto

$ sudo journalctl -u rke2-server | grep sqlite
Jul 30 22:21:26 server1 rke2[50472]: time="2024-07-30T22:21:26Z" level=info msg="Configuring sqlite3 database connection pooling: maxIdleConns=2, maxOpenConns=0, connMaxLifetime=0s"

$ sudo journalctl -u rke2-server | grep -i "Slow SQL"
Jul 30 22:22:55 server1 rke2[50472]: time="2024-07-30T22:22:55Z" level=info msg="Slow SQL (started: 2024-07-30 22:22:54.208840928 +0000 UTC m=+87.376282749) (total time: 1.107540778s): INSERT INTO kine(name, created, deleted, create_revision, prev_revision, lease, value, old_value) values(?, ?, ?, ?, ?, ?, ?, ?)"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants