address issue when running commands with #exec #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
just got hit by this |
|
Also affected by this 👍🏻 |
| end | ||
|
|
||
| desc "Watch and build your Tailwind CSS on file changes" | ||
| task :watch do | ||
| exec "#{TAILWIND_COMPILE_COMMAND} -w" | ||
| system "#{TAILWIND_COMPILE_COMMAND} -w" |
There was a problem hiding this comment.
Is there a reason exception: true is not used here? Even though the command is not expected to terminate, it can still fail to start in the first place.
There was a problem hiding this comment.
No reason other than it hasn't been a problem we needed to solve. If you'd like to submit a PR I'd consider merging it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to #181
After upgrading one of our repos to
2.0.11, we unfortunately learned that running commands withKernel#execinstead ofKernel#systemintroduces a failure in theassets:precompilepipeline. Due toexechijacking the process from Ruby, subsequent steps will not run after the tailwind build completes.This will probably need to be treated as an urgent bugfix as it may result in a failure of the asset pipeline to output images, javascript, etc.
This change effectively reverts #181, and adds the
exception: trueflag which will allow#systemto raise when encountering failure codes.