hms support

[romainfrancois]

library(hms)
library(vctrs)

time <- hms(56, 34, 12)
str(time)
#>  'hms' num 12:34:56
#>  - attr(*, "units")= chr "secs"

# losing the `hms` class, and therefore the printing
time2 <- vec_c(time, time)
str(time2)
#>  'difftime' num [1:2] 45296 45296
#>  - attr(*, "units")= chr "secs"

I realize hms is just disguise on top of difftime. Should there be perhaps a vec_restore.difftime, or would we need to add support for hms in the hms package ?

[hadley]

I think we just need a vec_restore.hms and then everything should just work.

[romainfrancois]

Maybe vec_type2 also:

> time <- hms::hms(56, 34, 12)
> vec_type(time)
hms()
> vec_type2(time, time)
Time difference of  secs

Otherwise, to never gets to be a hms in vec_restore

[hadley]

Actually, this belongs in hms. I'll move it there.

[hadley]

Now at tidyverse/hms#61