Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak blog post action order #1899

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Tweak blog post action order #1899

merged 1 commit into from
Oct 10, 2023

Conversation

hadley
Copy link
Member

@hadley hadley commented Oct 7, 2023

I assume the intent here is to get the blog post into the newly built site, but I found the order action a bit confusing, especially given that I like to be absolutely sure I'm getting the right url by copying it from the live site.

@hadley hadley requested a review from jennybc October 7, 2023 19:31
@jennybc
Copy link
Member

jennybc commented Oct 7, 2023

As previously foretold, here we go:

#1847 (review)

I'm going to ask @DavisVaughan to review.

Copy link
Member

@DavisVaughan DavisVaughan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this counters anything from the previous PR, so it looks good

I mentioned a chicken and egg problem here:
#1761 (comment)

But I think this workflow gets us around it nicely, for example:

  • Release blog post for 0.2.0 (blog post typically links back to pkgdown site home page, which will be at 0.1.0)
  • Add link to blog post for 0.2.0 in pkgdown news menu
  • Create a 0.2.0 commit that builds pkgdown site for 0.2.0 (this includes the blog post news menu item, and now the link in the blog post points to a 0.2.0 site too)
  • Market the blog post

The one thing you won't be able to easily do when publishing the blog post is link directly to the 0.2.0 NEWS section, i.e. like https://slider.r-lib.org/news/index.html#slider-030, since the 0.2.0 site won't be up when you publish the blog post. But that is ok, we can just link to the NEWS page itself instead, i.e. without the direct header link https://slider.r-lib.org/news/index.html

@jennybc
Copy link
Member

jennybc commented Oct 10, 2023

If you two are happy, I am happy!

@jennybc jennybc merged commit b24ec4d into main Oct 10, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants