Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

path_ext() returns correct extension if multiple dots present #452

Merged
merged 2 commits into from
Apr 27, 2024
Merged

path_ext() returns correct extension if multiple dots present #452

merged 2 commits into from
Apr 27, 2024

Conversation

IndrajeetPatil
Copy link
Contributor

Closes #382

@gaborcsardi gaborcsardi merged commit 342ac30 into r-lib:main Apr 27, 2024
13 checks passed
@gaborcsardi
Copy link
Member

Thank you!

@tentacles-from-outer-space
Copy link

Hi, nice to see it is fixed, but the same regex fix need to be done in path_ext_remove too:

> fs::path_ext_remove("aa..bb")
[1] "aa..bb"

@IndrajeetPatil IndrajeetPatil mentioned this pull request May 1, 2024
Merged
@IndrajeetPatil IndrajeetPatil deleted the b382-path-ext branch May 12, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

path_ext wrong when two dots present
3 participants
@IndrajeetPatil @gaborcsardi @tentacles-from-outer-space