Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support requesting and getting user consent #207

Closed
KitsuneRal opened this issue May 23, 2018 · 2 comments
Closed

Support requesting and getting user consent #207

KitsuneRal opened this issue May 23, 2018 · 2 comments
Assignees
@KitsuneRal
Labels
enhancement A feature or change request for the library

Comments

@KitsuneRal
Copy link
Member

So that users would not need to follow an external link in a browser just to give their consent.
@KitsuneRal
Copy link
Member Author

Related spec ticket: https://github.com/matrix-org/matrix-doc/issues/1252.

@KitsuneRal KitsuneRal self-assigned this May 28, 2018
@KitsuneRal KitsuneRal added the enhancement A feature or change request for the library label May 28, 2018
@KitsuneRal
Copy link
Member Author

Resorting to a browser is a necessary evil atm; but at least the library now provides the reasonable way to identify the error (StatusCode == UserConsentRequestedError) and the consent URL (BaseJob::errorUrl()), along with the conventional error message available in BaseJob::errorString().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KitsuneRal KitsuneRal

Labels
enhancement A feature or change request for the library
Projects
libQuotient 1
Status: Version 0.3 - Released
Milestone
No milestone
Development

No branches or pull requests
1 participant
@KitsuneRal