Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No need to setContents when container is empty #3539

Merged
merged 1 commit into from
Mar 3, 2022
Merged

Conversation

luin
Copy link
Member

@luin luin commented Feb 24, 2022

It's only necessary to call setContents() when html is not empty. Otherwise, we can avoid it for better performance.

@jhchen jhchen merged commit 0f20a58 into develop Mar 3, 2022
@jhchen jhchen deleted the zh-init-perf branch March 3, 2022 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants