Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compiler hook test gets 2nd-level error: COMPILATION-TOLERANCE slot missing #736

Closed
ghost opened this issue Oct 5, 2021 · 2 comments
Closed

Comments

@ghost
Copy link

ghost commented Oct 5, 2021

When running TEST-COMPILER-HOOK test, when it signals a tolerance error, i.e., quil::state-prep-compression-tolerance-error, a second-level error is signaled with an error message that looks something like this:

  When attempting to read the slot's value (slot-value), the slot
  COMPILATION-TOLERANCE is missing from the object
  #<CL-QUIL::STATE-PREP-COMPRESSION-TOLERANCE-ERROR {1005FD4043}>.

Here's code to reproduce this, assuming you're in a REPL with quil test system loaded and in CL-QUIL-TESTS package:

(%with-loose-state-prep-compression
  (error 'quil::state-prep-compression-tolerance-error
    :compilation-tolerance -2
    :compilation-precision -1))

This has recently been seen "in the wild" for a CI test associated with a recent and pending PR (#733). Here's a URL to the failing test: https://github.com/quil-lang/quilc/pull/733/checks?check_run_id=3759605488

@ghost
Copy link
Author

ghost commented Oct 5, 2021

Anyone know if there an issue already for the 1st-level error? I understand it's been ascribed to something like floating point imprecision by knowledgable folks such as @stylewarning

@stylewarning
Copy link
Member

I didn't see the first error in a quick scan; but it's definitely "well known" and ought to be logged if it's not already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant