Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bundle): use correct channel and operator name in subscription (PROJQUAY-2556) #524

Merged
merged 2 commits into from
Sep 28, 2021

Conversation

flavianmissi
Copy link
Contributor

the previously used values did not match the ones specified in the upstream manifests.

@flavianmissi
Copy link
Contributor Author

@jonathankingfc do you have time to give this another review round?

Copy link

@crozzy crozzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crozzy
Copy link

crozzy commented Sep 24, 2021

@flavianmissi seems like this repo is like quay/quay where you need a jira issue in the commit message

@flavianmissi
Copy link
Contributor Author

flavianmissi commented Sep 27, 2021

@flavianmissi seems like this repo is like quay/quay where you need a jira issue in the commit message

@crozzy how do go about it when there is no jira issue? create one for the sake of the commit check passing?

@BillDett
Copy link
Collaborator

@flavianmissi - you can reference one of the Jiras you're using already or just make a new one.

@flavianmissi flavianmissi changed the title fix(bundle): use correct channel and operator name in subscription fix(bundle): use correct channel and operator name in subscription (PROJQUAY-2556) Sep 28, 2021
@flavianmissi flavianmissi merged commit de26800 into quay:master Sep 28, 2021
@flavianmissi flavianmissi deleted the fix-bundle-sub-and-og branch September 28, 2021 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants