components: added tls managed component (PROJQUAY-2050) #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should make sure that the enhancement proposal is reviewed and merged before this is. |
alecmerdler
force-pushed
the
PROJQUAY-2050
branch
6 times, most recently
from
7741652
to
5809ca6
Compare
Adds a new managed component, 'tls'. This separates the 'route' component from TLS and allows users to configure both separately. 'EXTERNAL_TLS_TERMINATION: true' is the opinionated setting. Managed 'tls' means the default cluster wildcard cert is used. Unmanaged 'tls' means the user-provided cert/key pair will be injected into the 'Route'. Signed-off-by: Alec Merdler <alecmerdler@gmail.com>
alecmerdler
force-pushed
the
PROJQUAY-2050
branch
from
5809ca6
to
98d4aed
Compare
alecmerdler
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new managed component, 'tls'. This separates the
'route' component from TLS and allows users to configure
both separately. 'EXTERNAL_TLS_TERMINATION: true' is the
opinionated setting. Managed 'tls' means the default
cluster wildcard cert is used. Unmanaged 'tls' means
the user-provided cert/key pair will be injected into
the 'Route'.
Signed-off-by: Alec Merdler alecmerdler@gmail.com