Fix Managed Database Initialization (PROJQUAY-1664) #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #400 |
alecmerdler
force-pushed
the
PROJQUAY-1664
branch
5 times, most recently
from
39cd616
to
1485d65
Compare
Adds 'startupProbe' to managed Postgres 'Deployment' definition to prevent the pod from being killed before database initialization is complete. Signed-off-by: Alec Merdler <alecmerdler@gmail.com>
|
Tested this PR locally and while the Postgres issue appears to be fixed, the |
ricardomaraschini
added a commit
that referenced
this pull request
Jul 30, 2021
Following feedback there is now ay of getting the health of the mirror component. This PR removes the checks, essentially rolling back a change made by #427. As soon as we have a proper way of checking for the mirror health we will need to re-enable these.
ricardomaraschini
added a commit
that referenced
this pull request
Aug 10, 2021
* quay-operator: add resource requests and limits (PROJQUAY-2011) Signed-off-by: Daniel Messer <dmesser@redhat.com> * reconcile: Prevent unnecessary component enabling/disabling (PROJQUAY-2198) - Prevent HPA, Route, and Monitoring components from being enabled/disabled based on received config. - Block rollout on missing config fields * mirrorprobes: removing mirror pod probes (PROJQUAY-2226) (#485) Following feedback there is now ay of getting the health of the mirror component. This PR removes the checks, essentially rolling back a change made by #427. As soon as we have a proper way of checking for the mirror health we will need to re-enable these. * componentstatus: Reporting faulty condition for quay components (PROJQUAY-1609) (#484) Co-authored-by: dmesser <dmesser@redhat.com> Co-authored-by: Jonathan King <jonathankingfc@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://issues.redhat.com/browse/PROJQUAY-1664
Changelog: Fixes
role does not existerror for managed database component by addingstartupProbe.Docs: N/a
Testing: Create
QuayRegistrywith managed database and ensure all health checks pass.Details: Fixes an issue where the managed Postgres pod is killed before it completes initialization, and the next pod that starts up reports
role does not existerror. Followed the recommendations of the Postgres container maintainers and addedstartupProbewhich tells k8s when the container has finished initialization. Apparently thelivenessProbealways returns true.