Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were passing context such as the OpenShift cluster hostname, OBC connection info, and other required data using the
metadata.annotations
on theQuayRegistry
, then stripping out the annotations at the end of the reconcile loop. This was kind of a hack, but was done to maintain clean function interfaces without adding extra ad-hoc arguments.This pull request refactors the usage of annotations on the
QuayRegistry
object to instead use aQuayRegistryContext
, and pass that as the first argument to functions that rely on additional information.Addresses https://issues.redhat.com/browse/PROJQUAY-1576