Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev Override for Kustomize (PROJQUAY-992) #314

Merged
merged 1 commit into from
Sep 15, 2020

Conversation

alecmerdler
Copy link
Contributor

@alecmerdler alecmerdler commented Sep 15, 2020

Issue: https://issues.redhat.com/browse/PROJQUAY-992

Changelog: Allow overriding Kustomize using a defined ConfigMap.

Docs: N/a

Testing:

  1. Create ConfigMap called quay-dev-kustomize with the following contents in the kustomization.yaml key:
# Overlay variant for "dev".
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
commonAnnotations:
  quay-version: dev
bases:
  - ../../../tmp
images:
  - name: quay.io/projectquay/quay
    newName: quay.io/alecmerdler/quay
    newTag: dev
  1. Install Quay Operator using custom CatalogSource.
  2. Create QuayRegistry with spec.desiredVersion set to dev.

Operator should deploy Quay app container using the image override.

Details: By using Kustomize and having the static k8s files present in the Operator container, we lend ourselves to an escape hatch for overriding the deployed container images and other aspects of the QuayRegistry. This is done at the Operator level, so every QuayRegistry will be deployed using these overrides. Therefore this is for dev/debugging purposes and should not be used in production.

@alecmerdler alecmerdler force-pushed the PROJQUAY-992 branch 5 times, most recently from f931884 to 45db94e Compare September 15, 2020 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant