-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code Runner Overhaul #99
Conversation
@jmbuhr Curious to hear what you think about removing the It is a breaking change for existing users, but so is the new way that code runners are configured. |
Looks good, I'll play around with it on the weekend! :) |
This is shaping out nicely! |
Questions or requests for molten that would tie in nicely with the notebook experience (not required for the integration, just nice to haves):
|
I was at some point having issues without the
Yup, third keybinding here
Currently no, and also going to take some time b/c the current code assumes everywhere that there is only one output open at a time and that output is on screen and below the top line. But that is something I'm working on (here is the issue). I might implement other things before this gets finished but it'll get there eventually. |
I'm not sure what I was doing before, but it seems to work now |
@jmbuhr lmk if there's anything else that you want me to do with this. Also letting you know that I've added virtual text output to molten, which allows for more than one output to be open at a time. It's still 'pre-release' but it's been merged to main, and works well enough to use. |
Virtual text ist a cool solution for this! Is this ready to merge from your side? |
@jmbuhr Yup! ready to go. I don't have anything else to add to it. I've used this for like two weeks and it seems to work pretty well. |
Perfect! I'll merge this as is then :) |
closes #93
closes #81
General notes
:QuartoSend
andrequire('quarto').quartoSend()
functions (for now, thinking about removing the old lua functions), but there's now alsorequire('quarto.runner').run_cell(multi_lang: bool)
functions that give the user control over if the function runs multiple languages at once. I'm completely open to changing these function names if you want them to be more analogous to the current "send", "sendCell" etc.Things that are working
QuartoSendLine
yaml
)More changes before this PR is ready
Things I'm pushing off until a later PR