Excluding depencency from arc based on group id only results in NoSuchElementException

[jochemvv]

Describe the bug

When setting quarkus.arc.exclude-dependency..group-id, without quarkus.arc.exclude-dependency..artifact-id start up fails and a NoSuchElementException is thrown.

Expected behavior

It should be possible to exclude based on group-id only.

Actual behavior

Excluding based on group-id only, results in NoSuchElementException

How to Reproduce?

Reproducer:

1. add a exclude configuration, e.g. quarkus.arc.exclude-dependency.acme.group-id=org.acme
2. start the application

Output of uname -a or ver

No response

Output of java -version

No response

Quarkus version or git rev

No response

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response

[quarkus-bot]

/cc @Ladicek (arc), @manovotn (arc), @mkouba (arc)

[jochemvv]

seems like some parentheses are missing in BeanArchiveProcessor.archiveMatches.

I think the following:

public static boolean archiveMatches(ArtifactKey key, String groupId, Optional<String> artifactId, Optional<String> classifier) {
        if (Objects.equals(key.getGroupId(), groupId) && artifactId.isEmpty() || Objects.equals(key.getArtifactId(), artifactId.get())) {
            if (classifier.isPresent() && Objects.equals(key.getClassifier(), classifier.get())) {
                return true;
            }

            if (!classifier.isPresent() && "".equals(key.getClassifier())) {
                return true;
            }
        }

        return false;
    }

should be:

public static boolean archiveMatches(ArtifactKey key, String groupId, Optional<String> artifactId, Optional<String> classifier) {
        if (Objects.equals(key.getGroupId(), groupId) && (artifactId.isEmpty() || Objects.equals(key.getArtifactId(), artifactId.get()))) {
            if (classifier.isPresent() && Objects.equals(key.getClassifier(), classifier.get())) {
                return true;
            }

            if (!classifier.isPresent() && "".equals(key.getClassifier())) {
                return true;
            }
        }

        return false;
    }

[manovotn]

@jochemvv thank you for the report; you're correct that the if condition is wrong.
I've sent a PR and added a unit test.