Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SmallRye Health leaks MDC properties between health checks #41746

Closed
xstefank opened this issue Jul 8, 2024 · 1 comment · Fixed by #41815
Closed

SmallRye Health leaks MDC properties between health checks #41746

xstefank opened this issue Jul 8, 2024 · 1 comment · Fixed by #41815
Labels
Milestone

Comments

@xstefank
Copy link
Member

xstefank commented Jul 8, 2024

Describe the bug

Initially reported in #41711.

MDC properties are leaked between different HealthChecks. We probably need to configure some stickiness for the MDC in the health check.

It was probably caused by #37352.

Reproducer https://github.com/xstefank/quarkus-reproducers/tree/main/mdc-propagation.

Expected behavior

Same as in Quarkus 3.6.1:

10:11:32 INFO  health-check=TestHC [or.ac.TestHC] (executor-thread-1) Health check
10:11:32 INFO  health-check=TestHC2 [or.ac.TestHC2] (executor-thread-1) Health check

Actual behavior

In Quarkus 3.12.1:

10:10:20 INFO  health-check=TestHC [or.ac.TestHC2] (vert.x-worker-thread-5) Health check
10:10:20 INFO  health-check=TestHC [or.ac.TestHC] (vert.x-worker-thread-6) Health check

or

10:10:19 INFO  health-check=TestHC2 [or.ac.TestHC2] (vert.x-worker-thread-6) Health check
10:10:19 INFO  health-check=TestHC2 [or.ac.TestHC] (vert.x-worker-thread-5) Health check

How to Reproduce?

Reproducer https://github.com/xstefank/quarkus-reproducers/tree/main/mdc-propagation.

Output of uname -a or ver

No response

Output of java -version

No response

Quarkus version or git rev

No response

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

I'm already working on this.

@xstefank xstefank added the kind/bug Something isn't working label Jul 8, 2024
@quarkus-bot
Copy link

quarkus-bot bot commented Jul 8, 2024

/cc @Ladicek (smallrye), @jmartisk (health,smallrye), @phillip-kruger (smallrye), @radcortez (smallrye)

@quarkus-bot quarkus-bot bot added this to the 3.13 - main milestone Jul 11, 2024
@gsmet gsmet modified the milestones: 3.13 - main, 3.12.3 Jul 16, 2024
@gsmet gsmet modified the milestones: 3.12.3, 3.8.6 Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants