Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export security events as OTel Events #38008

Closed
brunobat opened this issue Jan 3, 2024 · 6 comments · Fixed by #39207
Closed

Export security events as OTel Events #38008

brunobat opened this issue Jan 3, 2024 · 6 comments · Fixed by #39207

Comments

@brunobat
Copy link
Contributor

brunobat commented Jan 3, 2024

Description

Since Relates to #37472 we have security related CDI events being generated.

This issue proposes to create a bridge made with a CDI observer that would listen to our internal events and create the OTel events... From there it's just OTel.
We could also use a property to enable/disable the bridge.

Please note that OTel Events are experimental and most APM providers don't have yet support for them, however this is an excellent use to demo these events.

The proposal comes from a mailing list discussion with @sberyozkin, here: https://groups.google.com/g/quarkus-dev/c/XoTFEXnvPhk/m/4yfKp1a7AQAJ?utm_medium=email&utm_source=footer

@quarkus-bot
Copy link

quarkus-bot bot commented Jan 3, 2024

/cc @sberyozkin (security), @michalvavrik

@brunobat
Copy link
Contributor Author

brunobat commented Jan 3, 2024

@sberyozkin, I think the bridge should live in the OTel extension. We should be able somehow to detect the classes generating these events, or we should be able to register/detect a capability when they are present. At build time we could activate the bridge.

@michalvavrik
Copy link
Member

It can live in OTel extension, including runtime Security SPI (that contains event interface) to OTel will do no harm (that's how we do it in other extensions where security is optional). This looks interesting, I can't look this month for various reasons, but unless you will not implement it, I'll take care of it in the next one. Thanks for suggestion.

@michalvavrik
Copy link
Member

OTel events and logs are currently not supported. From https://groups.google.com/g/quarkus-dev/c/uVg9BmUTC4o I know there will be work on logs. These two are related from what I can read https://opentelemetry.io/docs/specs/otel/logs/event-api/. @brunobat before I go ahead with this one, I suppose support for events must be added. How do I fit into this? Are you going to implement events anytime soon? I can have a look, but I don't want to collide with existing efforts (https://groups.google.com/g/quarkus-dev/c/uVg9BmUTC4o/m/jrZCG9ijAQAJ)

@brunobat
Copy link
Contributor Author

Events can also be added to current spans.
Will that work?

@michalvavrik
Copy link
Member

Events can also be added to current spans. Will that work?

Will explore that. thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants